Install option escaping#362
Open
notCalle wants to merge 3 commits intopuppetlabs:mainfrom
Open
Conversation
This performs the escaping, and splitting, of `install_options`, as documented in the README.
|
|
kenyon
approved these changes
Sep 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Provide a detailed description of all the changes present in this pull request.
Adds two utility functions to perform the escaping, and argument splitting for
install_options, as described in README#Install options with spaces.Additional Context
Add any additional context about the problem here.
Performing argument escape processing manually becomes very messy, and error prone, especially when the exact contents of arguments are composed from parameters.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist
puppet apply)